opensearch-project / ml-commons

ml-commons provides a set of common machine learning algorithms, e.g. k-means, or linear regression, to help developers build ML related features within OpenSearch.
Apache License 2.0
89 stars 126 forks source link

[BUG] Get conversation meta don't return application_type #2632

Closed Hailong-am closed 1 month ago

Hailong-am commented 1 month ago

Is your feature request related to a problem?

current get memory api https://opensearch.org/docs/latest/ml-commons-plugin/api/memory-apis/get-memory/ will return response like below, it miss application_type field.

{
  "memory_id": "gW8Aa40BfUsSoeNTvOKI",
  "create_time": "2024-02-02T18:07:06.887061463Z",
  "updated_time": "2024-02-02T19:01:32.121444968Z",
  "name": "Conversation for a RAG pipeline",
  "user": "admin"
}

mapping of system index .plugins-ml-memory-meta

{
  ".plugins-ml-memory-meta": {
    "mappings": {
      "_meta": {
        "schema_version": 1
      },
      "properties": {
        "application_type": {
          "type": "keyword"
        },
        "create_time": {
          "type": "date",
          "format": "strict_date_time||epoch_millis"
        },
        "name": {
          "type": "text"
        },
        "updated_time": {
          "type": "date",
          "format": "strict_date_time||epoch_millis"
        },
        "user": {
          "type": "keyword"
        }
      }
    }
  }
}

What solution would you like? A clear and concise description of what you want to happen.

What alternatives have you considered? A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context? Add any other context or screenshots about the feature request here.

Hailong-am commented 1 month ago

@Zhangxunmt As you add the application_type field in this PR https://github.com/opensearch-project/ml-commons/pull/1730/files/c1e8e2fb772cb38f3de9598b0606494eb1c3f236#diff-c99fc312519dcb3fa952ea768ddcd6139fa9349669c111c186270e2869b98fdf.

Want to confirm with you does this application_type not return by intention? is there a specific reason or we just miss it?

Zhangxunmt commented 1 month ago

This is expected. Not a bug. Already discussed this issue in other threads.