opensearch-project / neural-search

Plugin that adds dense neural retrieval into the OpenSearch ecosytem
Apache License 2.0
64 stars 66 forks source link

[Tech debt] Improve test coverage - phase 1, meet minimal required level #429

Open martin-gaievski opened 1 year ago

martin-gaievski commented 1 year ago

Improve test coverage for repo, all packages should be above 80%.

Currently report is showing following packages that are below 80%:

Steps to repro:

  1. Check above links for code coverage report. Click on every class and check which lines or methods are not covered, write tests for those lines.
  2. If you write unit test and want to run it, do
    ./gradlew test

    that will execute changes. If you want to check how coverage changes after adding your test, you need to create a new PR with your changes, mark it as "Draft" and let CI run. Part of the CI execution is generation of new coverage report with your changes.

Some tips:

dbwiddis commented 2 months ago

It would probably be helpful to post the coverage report link in the issue description :)