search

opensearch-project / neural-search

Plugin that adds dense neural retrieval into the OpenSearch ecosytem
Apache License 2.0
57 stars 58 forks source link

Cleanup integ tests by removing redundant model uploads #671

Closed martin-gaievski closed 3 months ago

martin-gaievski commented 3 months ago

Description

Cleaning integ tests by removing redundant model uploads. Model upload/delete consumes lot of resources including memory for keeping local model. That is a problem for jdk21 (default for distribution infra) as default GC may be slow with memory cleanup and tests will fail in environment with limited heap amount.

In this PR I've removed model upload from 12 out of 64 tests. Logic of these test remains unchanged, those models were not necessary as queries are text based (bm25) queries.

Issues Resolved

https://github.com/opensearch-project/neural-search/issues/667

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

vibrantvarun commented 3 months ago

LGTM, thanks @martin-gaievski