Closed vibrantvarun closed 2 months ago
BWC tests are failing because of https://github.com/opensearch-project/neural-search/issues/688
BWC tests are failing because of https://github.com/opensearch-project/ml-commons/issues/2333
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.42%. Comparing base (
cc6a6b2
) to head (27cc05d
). Report is 10 commits behind head on main.:exclamation: Current head 27cc05d differs from pull request most recent head 64e9d46. Consider uploading reports for the commit 64e9d46 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The backport to 2.x
failed:
The process '/usr/bin/git' failed with exit code 1
To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-694-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 86f6d4c62d02e953aa31d5d7a5b9716b93a3d8a2
# Push it to GitHub
git push --set-upstream origin backport/backport-694-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x
Then, create a pull request where the base
branch is 2.x
and the compare
/head
branch is backport/backport-694-to-2.x
.
@vibrantvarun Can you do a manual backport PR to 2.x? Since this code change is causing other 2.x backport PR CI failure.
Waiting for ml-commons PR to get merged
Description
This PR contains following
Issue
https://github.com/opensearch-project/neural-search/issues/640
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.