opensearch-project / neural-search

Plugin that adds dense neural retrieval into the OpenSearch ecosytem
Apache License 2.0
57 stars 58 forks source link

Fix: change max chunk limit exception #717

Closed yuye-aws closed 2 months ago

yuye-aws commented 2 months ago

Description

Fix the issue: https://github.com/opensearch-project/neural-search/issues/716. You can check the issue for more examples.

Issues Resolved

Fix the issue: https://github.com/opensearch-project/neural-search/issues/716

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

yuye-aws commented 2 months ago

@zhichao-aws Can you rerun the gradle checks?

zhichao-aws commented 2 months ago

@zhichao-aws Can you rerun the gradle checks?

I re-runed it multiple times but still get same exception.

yuye-aws commented 2 months ago

@model-collapse @zane-neo This PR is ready for review now

yuye-aws commented 2 months ago

@zhichao-aws Can you rerun the gradle checks?

I re-runed it multiple times but still get same exception.

These test failures are due to model deploy issue, which is not related with this PR. We can focus on these test failures later.