opensearch-project / neural-search

Plugin that adds dense neural retrieval into the OpenSearch ecosytem
Apache License 2.0
56 stars 58 forks source link

[FEATURE] Add retry for BWC tests #778

Open chishui opened 3 weeks ago

chishui commented 3 weeks ago

Is your feature request related to a problem?

BWC tests are quite flaky, here is one failed test example:

We can introduce retry for BWC tests to reduce the chance of random failures.

What solution would you like?

OpenSearch core repo uses test-retry plugin to retry flaky tests: https://github.com/opensearch-project/OpenSearch/blob/main/build.gradle#L469

What alternatives have you considered?

N/A

Do you have any additional context?

N/A

dblock commented 2 days ago

[Catch All Triage - Attendees 1, 2, 3, 4, 5]

dblock commented 2 days ago

Double check that the errors are truly transient. Retrying often just hides eventual consistency errors and is not recommended.

[Catch All Triage - Attendees 1, 2, 3, 4, 5]