opensearch-project / observability

Visualize and explore your logs, traces and metrics data in OpenSearch Dashboards
https://opensearch.org/docs/latest/observability-plugin/index/
Apache License 2.0
53 stars 95 forks source link

Updates sample cert and admin keystore #1806

Closed DarshitChanpura closed 3 months ago

DarshitChanpura commented 4 months ago

Description

Downstream change coming from security plugin: https://github.com/opensearch-project/security/pull/4061

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

DarshitChanpura commented 4 months ago

should be merged post https://github.com/opensearch-project/security/pull/4061 is merged

DarshitChanpura commented 4 months ago

can you leave some comments as to why this change is needed?

Downstream change coming from security plugin: https://github.com/opensearch-project/security/pull/4061 CI will start failing because of certificate mismatch, since the public certificates used are updated, thus sample.pem will not be verifiable since it has old certs

Can you provide a mechanism to pull these in via security plugin?

This is left onto maintainers to refactor build.gradle to pull artifacts from security repository. Refer to k-NN's build.gradle.

These certificates should not be hardcoded in individual plugin repos instead they should be pulled from security-plugin as needed. Even better solution would be to generate own certificates and setup the configuration as required, thus avoiding any dependency on security plugin's certificates.

gaiksaya commented 3 months ago

Hello reviewers,

This could be potential reason for failing tests with security atleast at the distribution level for 2.13.0. Please review and merge. Looks like it would need backport to 2.x and 2.13?

Thanks!