dblock commented 2 weeks ago

Description

We used coverage/test-spec-coverage-${{ matrix.entry.version }}-${{ matrix.entry.tests || 'default' }}.json to make the coverage output file name, which may have contained / in cases like plugins/index-management. This caused the coverage merge code not to pickup those files because it's looking for test-spec-coverage-*.

This fixes that by using the hash instead of the path name. The version still needs to be there to make it unique.

The result as expected is slightly better than in previous PRs (e.g. here vs. https://github.com/opensearch-project/opensearch-api-specification/pull/661).

We also display paths that don't have tests when merging results so it's easier to identify tests to fill out.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 2 weeks ago

Changes Analysis

Commit SHA: 6902eaae3e99c453b74ca58e71ed2d701da37f79 Comparing To SHA: 62f1f5f7418f48ee8002f2833eb58043ab47d82e

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11785290598/artifacts/2173027532

API Coverage

	Before	After	Δ
Covered (%)	588 (57.59 %)	588 (57.59 %)	0 (0 %)
Uncovered (%)	433 (42.41 %)	433 (42.41 %)	0 (0 %)
Unknown	40	40	0