dblock commented 5 days ago

Description

Fix response from /_scripts/painless/_execute which can only be a primitive.
Fix request from /_scripts/painless/_execute which don't always require query.
Fix Hit that can contain array fields with primitives (e.g. ratings_sum: [6]).
Misc tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 5 days ago

Changes Analysis

Commit SHA: 8234f33c1ac953560c1e42bf37515fb89ff349e2 Comparing To SHA: 4f27c67d3f249ef9fd16ff027d7b028736f3c117

API Changes

Summary

├─┬Paths
│ └─┬/_scripts/painless/_execute
│   ├─┬GET
│   │ └─┬Responses
│   │   └─┬200
│   │     └─┬application/json
│   │       └─┬Schema
│   │         └─┬result
│   │           ├──[➖] type (30340:23)❌ 
│   │           ├──[➕] oneOf (30341:21)
│   │           ├──[➕] oneOf (30342:21)
│   │           └──[➕] oneOf (30343:21)
│   └─┬POST
│     └─┬Responses
│       └─┬200
│         └─┬application/json
│           └─┬Schema
│             └─┬result
│               ├──[➖] type (30340:23)❌ 
│               ├──[➕] oneOf (30341:21)
│               ├──[➕] oneOf (30342:21)
│               └──[➕] oneOf (30343:21)
└─┬Components
  ├─┬_core.scripts_painless_execute___PainlessContextSetup
  │ └──[➖] required (43607:11)❌ 
  └─┬_core.search___Hit
    └─┬fields
      └──[🔀] additionalProperties (44098:33)❌

Document Element	Total Changes	Breaking Changes
components	2	2
paths	8	2

❌ BREAKING Changes: 4 out of 10
Modifications: 1
Removals: 3
Additions: 6
Breaking Removals: 3
Breaking Modifications: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12052353134/artifacts/2244896881

API Coverage

	Before	After	Δ
Covered (%)	599 (58.67 %)	599 (58.67 %)	0 (0 %)
Uncovered (%)	422 (41.33 %)	422 (41.33 %)	0 (0 %)
Unknown	42	42	0