search

opensearch-project / opensearch-benchmark-workloads

Official workloads used by OpenSearch Benchmark (OSB)
https://opensearch.org/docs/latest/benchmark/
11 stars 58 forks source link

[README] Add contribution guide reference to README #293 #299

Closed safimuhammad closed 1 month ago

safimuhammad commented 1 month ago

…enchmark/user-guide/contributing-workloads/#testing-the-workload added to the readme.

Description

Tried resolving issue #293 by adding an official contribution guide directly in the main Readme.

Issues Resolved

Now contributors can directly refer to the main Readme for official contribution guidelines instead of an external link.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cgchinmay commented 1 month ago

@safimuhammad Thanks for the PR. you need to sign your commit for DCO check to pass.

safimuhammad commented 1 month ago

I have signed the commits the DCO is still failing.

safimuhammad commented 1 month ago

@cgchinmay the commit messages include the sign-off and yet it still declines, is there anything I am missing?

cgchinmay commented 1 month ago

@cgchinmay the commit messages include the sign-off and yet it still declines, is there anything I am missing?

you may need to amend your previous commit with sign-off.

safimuhammad commented 1 month ago

Thanks, fixed it.

safimuhammad commented 1 month ago

Thanks @IanHoang said changes are done please have a look.