search

opensearch-project / opensearch-benchmark

OpenSearch Benchmark - a community driven, open source project to run performance tests for OpenSearch
https://opensearch.org/docs/latest/benchmark/
Apache License 2.0
107 stars 75 forks source link

Support opensearch-py Client Connections (urllib3httpconnection, requestshttpconnection) #437

Open saimedhi opened 8 months ago

saimedhi commented 8 months ago

Is your feature request related to a problem? Please describe. The objective is to extract opensearch-py client performance metrics in opensearch-benchmark with various connections (urllib3httpconnection, requestshttpconnection, aiohttpconnection). The current code exclusively uses aiohttpconnection. Historically, opensearch-benchmark supported urllib3httpconnection, and at a different time, aiohttpconnection. Aim to introduce the flexibility to choose between these connections, allowing users to gain insights into their respective performances.

Describe the solution you'd like Enable opensearch-benchmark to work with urllib3httpconnection and requestshttpconnection for opensearch-py client. Provide an option to switch the client connection using an argument in the execute-test command.

gkamat commented 8 months ago

It will be ideal to be able to have OSB support different clients. The precise mechanism and interfaces need to be properly scoped out and designed. Meanwhile, would suggest changing the title of this PR -- "multiple" often implies "concurrent".

saimedhi commented 8 months ago

I am working on this issue.