opensearch-project / opensearch-benchmark

OpenSearch Benchmark - a community driven, open source project to run performance tests for OpenSearch
https://opensearch.org/docs/latest/benchmark/
Apache License 2.0
111 stars 78 forks source link

The expand-data-corpus script runs into exceptions in some scenarios #600

Closed gkamat closed 1 month ago

gkamat commented 3 months ago

Describe the bug

Description

When _expand_datacorpus is run without OSB having been set up (the script documentation indicates this is required, though), users see a confusing error message:

[ERROR] Cannot execute-test. Error in test execution orchestrator (Workload 'http_logs' is invalid.

Error details: [] should be non-empty
Instance: []
Path: deque(['indices'])
Schema path: deque(['properties', 'indices', 'minItems']))

There are other exceptions that show up if the http_logs data corpus is not present or if the corpus size is not provided.

Yet another issue is that, if the user chooses to run the script on Docker, the steps to do that are not documented. This case should be added to the help message, since the corpus needs to be generated within the Docker container.

To reproduce

Run expand-data-corpus.py on a host or in a Docker container without having run OSB first.

IanHoang commented 1 month ago

Change has been merged in.