search

opensearch-project / opensearch-build-libraries

Apache License 2.0
6 stars 24 forks source link

Upgrade groovy library for Validation Workflow #388

Closed Divyaasm closed 6 months ago

Divyaasm commented 6 months ago

Description

Pass each argument from jenkins separately to Validation groovy library

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.36%. Comparing base (120cc3a) to head (6407739).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #388 +/- ## ========================================= Coverage 86.36% 86.36% Complexity 29 29 ========================================= Files 86 86 Lines 220 220 Branches 12 12 ========================================= Hits 190 190 Misses 22 22 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rishabh6788 commented 6 months ago

This will also need a version bump, right?

Divyaasm commented 6 months ago

This will also need a version bump, right?

Yes

rishabh6788 commented 6 months ago

This will also need a version bump, right?

Yes

You need to update the build.gradle file for that, right?

Divyaasm commented 6 months ago

This will also need a version bump, right?

Yes

You need to update the build.gradle file for that, right?

Waiting for this PR to get merged,

This will also need a version bump, right?

Yes

You need to update the build.gradle file for that, right?

Yes Rishabh

peterzhuamazon commented 6 months ago

Please bump version.