search

opensearch-project / opensearch-build-libraries

Apache License 2.0
6 stars 23 forks source link

Update gradle-check index mapping to make it generic and match old index fields #434

Closed prudhvigodithi closed 1 month ago

prudhvigodithi commented 1 month ago

Description

Update gradle-check index mapping to make it generic and match old index fields.

Issues Resolved

To ensure the OpenSearch Gradle Check Metrics visualizations does not break and load the new fields as the new indices are created. Part of https://github.com/opensearch-project/opensearch-metrics/issues/39

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

rishabh6788 commented 1 month ago

Can you also update the new field corresponding to pr_description and commit_message?

prudhvigodithi commented 1 month ago

@rishabh6788 the pr_description was renamed to pull_request_title and today we dont have the commit_message field coming in. Also there no usage of pr_description in any visualizations at this point.

rishabh6788 commented 1 month ago

Added new fields to gradle check workflow, we need to read the new env var pr_owner and pr_or_commit_description in the shell script and jenkinsfile. https://github.com/opensearch-project/OpenSearch/commit/4700be3e72e9193d438718120d1228222785786c

prudhvigodithi commented 1 month ago

Thanks the pull_request_owner already exists and we have the git_reference that links to the github with all the details, I dont think so we need the pr_or_commit_description that adds the commit message.