search

opensearch-project / opensearch-build-libraries

Apache License 2.0
6 stars 25 forks source link

[Bug]: The `gh issue list` used in libraries having `--label` flag creates a new issue for the same title and different labels. #441

Closed prudhvigodithi closed 3 months ago

prudhvigodithi commented 3 months ago

Describe the bug

The gh CLI command gh issue list does not match issues with the same title but different labels. Consequently, if you create an issue with the same title but different labels, a new issue is created. This behavior is observed when using the --label flag with the gh issue list command.

To reproduce

Screenshot 2024-06-12 at 3 09 58 PM

Expected behavior

Even though the issue has different labels, if the title is same during the gh issue list it should skip the issue creation.

Screenshots

If applicable, add screenshots to help explain your problem.

Host / Environment

No response

Additional context

No response

Relevant log output

No response

peterzhuamazon commented 3 months ago

The runners are using gh client version 2.42.0.

prudhvigodithi commented 3 months ago

[Triage] Thanks @peterzhuamazon AFAIK we dont need a --label flag here for gh issue list, as the labels can always be updated manually by users and with automation, we dont need to have a hard check on issue with exact label match, as long as the issue exists matching the title that we specified we should be good. @gaiksaya @getsaurabh02

prudhvigodithi commented 3 months ago

This issue is now resolved as the change has been included in the library release starting from version 6.5.0. Thank you