search

opensearch-project / opensearch-build-libraries

Apache License 2.0
7 stars 25 forks source link

Remove labels arg for closing GH issue #531

Closed gaiksaya closed 1 month ago

gaiksaya commented 1 month ago

Description

See the library here https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/closeGithubIssue.groovy Labels are not required in the code execution. Removing non required args

Issues Resolved

closes https://github.com/opensearch-project/opensearch-build-libraries/issues/529

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

peterzhuamazon commented 1 month ago

Will remove the label requirement cause some issues with same name to be mistakenly closed?

gaiksaya commented 1 month ago

Will remove the label requirement cause some issues with same name to be mistakenly closed?

No the label arg is complete ignore in the library. https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/closeGithubIssue.groovy#L22-L28

gaiksaya commented 1 month ago

Please bump version.

Done! It was 7.0.1 which was unreleased but this qualifies for minor bump as well.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.72%. Comparing base (8d86c41) to head (4edd4a6). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #531 +/- ## ========================================= Coverage 84.72% 84.72% Complexity 105 105 ========================================= Files 115 115 Lines 648 648 Branches 71 71 ========================================= Hits 549 549 Misses 29 29 Partials 70 70 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.