search

opensearch-project / opensearch-build-libraries

Apache License 2.0
7 stars 25 forks source link

Add ci-group arg for OSD integ tests #567

Open rishabh6788 opened 1 week ago

rishabh6788 commented 1 week ago

Description

Add ci-group arg for OSD integ tests.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.79%. Comparing base (e6ec7d1) to head (f186299).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #567 +/- ## ============================================ + Coverage 84.75% 84.79% +0.04% Complexity 114 114 ============================================ Files 117 119 +2 Lines 682 684 +2 Branches 75 75 ============================================ + Hits 578 580 +2 Misses 30 30 Partials 74 74 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gaiksaya commented 18 hours ago

Can you also please add library definitions to these 2 libraries. Something similar to https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/publishDistributionBuildResults.groovy#L10-L19 Looks like we missed a lot of them for old ones. Might be a good idea to use this opportunity to fix these 2 for now.