opensearch-project / opensearch-build

🧰 OpenSearch / OpenSearch-Dashboards Build Systems
Apache License 2.0
136 stars 271 forks source link

[Bug] Convert opensearch-docker-entrypoint.sh script into python #1541

Open peternied opened 2 years ago

peternied commented 2 years ago

Related https://github.com/opensearch-project/opensearch-build/issues/1529

Based on operation system configuration some command line utilities such as cat/sed/tee can have different behavior. In order to make the startup behavior consistent and testable lets move this script to python, which is included in the docker image already.

Acceptance Criteria:

gaiksaya commented 2 years ago

[Triage] We need to investigate the benefits of python over shell and vice versa.

dblock commented 2 years ago

I would prefer extracting much of what the code in shell scripts does into the product itself. For example, turning security on/off in the configuration file could become a command-line flag, etc.