Open prudhvigodithi opened 2 years ago
Can you please add your thoughts? This would clean the repo root folder and would better organize the scripts. @opensearch-project/engineering-effectiveness
That is a huge change especially the build.sh/test.sh/assemble.sh/sign.sh etc. A lot of the libs and code needs to accommodate this change. Need to approach with caution, and I dont think it is very urgent to make this change right now.
Similar related issue: https://github.com/opensearch-project/opensearch-build/issues/153
I would like to work on this
I identified 11 scripts as of now
$ ls | grep .sh
assemble.sh
build.sh
checkout.sh
ci.sh
manifests.sh
release_notes.sh
report.sh
run.sh
sign.sh
test.sh
validation.sh
I moved them to the scripts folder and I am updating the paths.
Is your feature request related to a problem? Please describe
There are multiple bash scripts that are part of the root folder, there is an already exists scripts/ folder. It would be clean to move the
.sh
files from the root to folder and store them underscripts/
.Describe the solution you'd like
Move all the
.sh
scripts that involve the workflows toscripts/
folder.Once migrated call the
.sh
file from the script folder. Example forrelease_notes.sh
: Instead of./release_notes.sh check manifests/2.2.0/opensearch-2.2.0.yml --date 2022-07-26
Run:./scripts/release_notes.sh check manifests/2.2.0/opensearch-2.2.0.yml --date 2022-07-26
To achieve this move
run.sh
,Pipfile Pipfile.lock
toscripts/
folder.Modify the
.sh
scripts as follows Examplerelease_notes.sh
SPDX-License-Identifier: Apache-2.0
#
The OpenSearch Contributors require contributions made to
this file be licensed under the Apache-2.0 license or a
compatible open source license.
set -e
DIR="$(dirname "$0")" "$DIR/run.sh" "$DIR/../src/run_releasenotes_check.py" $@