opensearch-project / opensearch-build

🧰 OpenSearch / OpenSearch-Dashboards Build Systems
Apache License 2.0
136 stars 271 forks source link

Build repo: Move all `.sh` scripts from root folder to `scripts/` folder. #2495

Open prudhvigodithi opened 2 years ago

prudhvigodithi commented 2 years ago

Is your feature request related to a problem? Please describe

There are multiple bash scripts that are part of the root folder, there is an already exists scripts/ folder. It would be clean to move the .sh files from the root to folder and store them under scripts/.

Describe the solution you'd like

SPDX-License-Identifier: Apache-2.0

#

The OpenSearch Contributors require contributions made to

this file be licensed under the Apache-2.0 license or a

compatible open source license.

set -e

DIR="$(dirname "$0")" "$DIR/run.sh" "$DIR/../src/run_releasenotes_check.py" $@



### Describe alternatives you've considered

_No response_

### Additional context

_No response_

###  Acceptance Criteria 

- Move the bash scripts to a specific folder.
- Update the [libraries](https://github.com/opensearch-project/opensearch-build-libraries/tree/main/vars) to use the scripts from this folder (Example https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/assembleManifest.groovy#L15)
- Update all the jenkinsfiles (part of the build repo and other repos used for one click release process) with the version of the library that use the scripts from this folder. 
prudhvigodithi commented 2 years ago

Can you please add your thoughts? This would clean the repo root folder and would better organize the scripts. @opensearch-project/engineering-effectiveness

peterzhuamazon commented 2 years ago

That is a huge change especially the build.sh/test.sh/assemble.sh/sign.sh etc. A lot of the libs and code needs to accommodate this change. Need to approach with caution, and I dont think it is very urgent to make this change right now.

prudhvigodithi commented 2 years ago

Similar related issue: https://github.com/opensearch-project/opensearch-build/issues/153

vchrombie commented 11 months ago

I would like to work on this

vchrombie commented 11 months ago

I identified 11 scripts as of now

$ ls | grep .sh
assemble.sh
build.sh
checkout.sh
ci.sh
manifests.sh
release_notes.sh
report.sh
run.sh
sign.sh
test.sh
validation.sh

I moved them to the scripts folder and I am updating the paths.