search

opensearch-project / opensearch-build

🧰 OpenSearch / OpenSearch-Dashboards Build Systems
Apache License 2.0
136 stars 271 forks source link

[BUG] OSD integTest lack additional_config entrypoint for both OS and OSD clusters #3589

Open peterzhuamazon opened 1 year ago

peterzhuamazon commented 1 year ago

Hi,

This is related to OSD specific integTest.

In OS, the additional config entry can be grab from the opensearch-<>-test.json and added to the opensearch.yml.

In OSD, this functional is half-complete in service_opensearch_dashboards.py and only allow hardcoded entries, without interpreting the entries from opensearch-dashboards-<>-test.json.

Moreover, in OSD integTest you need to start both OS and OSD, means the additional config in OS also need a new param to hold, so it wont get mixed up with OSD additional config. Right now both are under additional-cluster-configs key and will both be pushed to opensearch_dashboards.yml.

Thank.

peterzhuamazon commented 1 year ago

Only partially resolved this issue in PR:

gaiksaya commented 1 year ago

[Triage] The issue is partially resolved.

peterzhuamazon commented 11 months ago

We have implemented the OSD side of configs already. As for OS configs during OSD test there does not seems to have a specific need from plugins. Will close this issue for now until further notices. Thanks.

peterzhuamazon commented 7 months ago

Seems like there is a use case here:

kavilla commented 5 months ago

Low priority: for OpenSearch Dashboards we set cluster.routing.allocation.disk.threshold_enabled=false in our GitHub workflows. It would be a nice-to-have feature to be configure OpenSearch when we needed

Priority is low because we should figure out why that threshold is being hit.

ashwin-pc commented 5 months ago

I wouldn't categorize this as a low priority since this is blocking running the tests with the same environment today locally and in the infra pipeline. Having identical test environments is key to reproducibility. Figuring out why we have to increase the memory limits is a different issue and I don't think we should tie the two together since that may be a bigger problem to solve and we shouldn't hold off on this feature on the hopes that that will be resolved.