search

opensearch-project / opensearch-build

🧰 OpenSearch / OpenSearch-Dashboards Build Systems
Apache License 2.0
140 stars 273 forks source link

Remove the hard-coded copy of installation script during assembly #445

Open dblock opened 3 years ago

dblock commented 3 years ago

Is your feature request related to a problem? Please describe.

The assemble code in https://github.com/opensearch-project/opensearch-build/blob/59f2150707281d18931f2d2d292f9ab81267cdb5/bundle-workflow/src/run_assemble.py#L38 hard-codes a script to copy into the distribution. We want to remove the hard-coded copy and have a script_finder call that locates the path for additional files to copy into the assembly, so that will scale to supporting multiple platforms in the future and OpenSearch dashboards.

Acceptance Criteria installation script needs to be called using script_finder library

gaiksaya commented 2 years ago

@dblock , is this issue still valid?

dblock commented 2 years ago

Yes, it is still valid. We could swap it for a TODO as well.

Spectorisimo commented 1 year ago

Hello @dblock, can I work on this issue?

vchrombie commented 1 year ago

I think the issue is resolved. I don't see any paths hard coded in the file as of now. opensearch-project/opensearch-build -- src/run_assemble.py @71ccd7b

Can we close the issues if it is true? Please let me know if I am wrong.