[Bug]: Version bump PR for functional test repo failed to update pack-lock.json

opensearch-project / opensearch-build

🧰 OpenSearch / OpenSearch-Dashboards Build Systems

Apache License 2.0

137 stars 272 forks source link

Open zelinh opened 6 months ago

zelinh commented 6 months ago

The auto-generated version bump PR for functional test repo didn't include package-lock.json file. e.g. https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/1216

Run the current GHA Increment OpenSearch Dashboards Plugins Version

All two json files should have version incremented.

prudhvigodithi commented 5 months ago

Hey @zelinh that is done on purpose as AFAIK for FT repo we dont package-lock.json file, here are some sample old PR's that only increments package.json https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/1206/files https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/1121 Adding @AMoo-Miki to confirm.

@bbarani @Divyaasm

AMoo-Miki commented 5 months ago

Yeah; we shouldn't need to bump it but it could help with tracking if we ever need to do so (which we have never needed to).

rishabh6788 commented 3 months ago

Do we have a consensus on whether it should or should not be included? @AMoo-Miki

AMoo-Miki commented 3 days ago

Thinking about it more, we should keep the versions in the lock file and the manifest in sync.

prudhvigodithi commented 2 days ago

There is some discussion in past https://github.com/opensearch-project/opensearch-build/issues/3856 related to yarn.lock file. If just adding package-lock.json is required then:

Ensure that the lock file is updated as part of the version increment plugin helper (node ../../scripts/plugin_helpers version).
Add the file to git commit https://github.com/opensearch-project/opensearch-build/blob/main/.github/workflows/osd-increment-plugin-versions.yml#L193.

Thank you @peterzhuamazon @getsaurabh02