opensearch-project / opensearch-cli

A full-featured command line interface (CLI) for OpenSearch.
https://opensearch.org/docs/latest/clients/cli/
Apache License 2.0
44 stars 24 forks source link

Refactor create config file #36

Closed VijayanB closed 2 years ago

VijayanB commented 2 years ago

Signed-off-by: Vijayan Balasubramanian balasvij@amazon.com

Description

chmod doesn't work for windows operating system. Hence, in windows don't create default config file and check for permission. This will let users responsible for creating their own config file and set appropriate permission.

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov-commenter commented 2 years ago

Codecov Report

Merging #36 (5a21dae) into main (d966330) will increase coverage by 0.07%. The diff coverage is 76.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   67.19%   67.26%   +0.07%     
==========================================
  Files          30       31       +1     
  Lines        1844     1848       +4     
==========================================
+ Hits         1239     1243       +4     
  Misses        499      499              
  Partials      106      106              
Flag Coverage Δ
opensearch-cli 67.26% <76.00%> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/root.go 81.81% <ø> (+4.67%) :arrow_up:
commands/file_operation_unix.go 73.91% <73.91%> (ø)
commands/profile.go 51.66% <100.00%> (-1.06%) :arrow_down:
VijayanB commented 2 years ago

Tested in windows Screen Shot 2021-11-18 at 12 13 17 PM

Tested in unix type os ( macOs) Screen Shot 2021-11-18 at 12 15 48 PM