Remove mapping types - Githubissues

opensearch-project / opensearch-cli

A full-featured command line interface (CLI) for OpenSearch.

https://opensearch.org/docs/latest/clients/cli/

Apache License 2.0

44 stars 24 forks source link

Remove mapping types #47

Closed dreamer-89 closed 2 years ago

dreamer-89 commented 2 years ago

As part of v2.0 release, mapping types are getting removed from OpenSearch engine. Below are the changes in the opensearch-engine.

Removal of type from rest end-points
Removal of include_type_name parameter from API requests.

As part of this issue, please verify if type removal change on OpenSearch engine impacts this repository. If yes, then please remove the type references/usage from this repository

Top level changes are captured in gist below: https://gist.github.com/dreamer-89/d76eaf639171e8ab32fa7f8b9d6c93d3

For more detailed changes, please check meta issue below: Related: OpenSearch-engine meta issue

VijayanB commented 2 years ago

CLI doesn't use any rest endpoint which uses mapping type/include_type_name.

dreamer-89 commented 2 years ago

@VijayanB : Did you get a chance to go through all the changes captured in gist ? There are some changes in rest client, internal server classes which are used abundantly in other plugin repos. https://gist.github.com/dreamer-89/d76eaf639171e8ab32fa7f8b9d6c93d3

VijayanB commented 2 years ago

@VijayanB : Did you get a chance to go through all the changes captured in gist ? There are some changes in rest client, internal server classes which are used abundantly in other plugin repos. https://gist.github.com/dreamer-89/d76eaf639171e8ab32fa7f8b9d6c93d3

CLI accepts mapping as dynamic value from the user input. I added an integration test against OpenSearch 2.0. It didn't fail as expected.