opensearch-project / opensearch-cli

A full-featured command line interface (CLI) for OpenSearch.
https://opensearch.org/docs/latest/clients/cli/
Apache License 2.0
44 stars 24 forks source link

add the form-data-file flag to the curl post command to send multipart/form-data requests #77

Closed jnschbrt closed 1 year ago

jnschbrt commented 1 year ago

Description

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

wbeckler commented 1 year ago

Wow, thank you for contributing! @VachaShah would you be willing to take a look?

jnschbrt commented 1 year ago

Hi @VachaShah ,

have you had time to look at the new changes? :)

VachaShah commented 1 year ago

Hi @jnschbrt, apologies for the delay here! I just added a comment.

jnschbrt commented 1 year ago

The changes related to the feature look good to me. The untriaged workflow is already part of the main so we can remove it from the PR.

removed

VachaShah commented 1 year ago

Hi @jnschbrt, can you merge the latest changes from main to your feature branch. The build failure was fixed in the latest commit. This will make the CI green and we can merge this PR.

jnschbrt commented 1 year ago

Hi @VachaShah

merged the main into my branch

VachaShah commented 1 year ago

@jnschbrt Thank you for your patience on this PR! I see a build failure happening due to lint errors: https://github.com/opensearch-project/opensearch-cli/actions/runs/5069380734/jobs/9139305477?pr=77. Can you please take a look?

jnschbrt commented 1 year ago

done @VachaShah

codecov[bot] commented 1 year ago

Codecov Report

Merging #77 (45d088e) into main (d641c9b) will decrease coverage by 0.63%. The diff coverage is 37.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   65.23%   64.60%   -0.63%     
==========================================
  Files          32       32              
  Lines        2278     2328      +50     
==========================================
+ Hits         1486     1504      +18     
- Misses        686      716      +30     
- Partials      106      108       +2     
Flag Coverage Δ
opensearch-cli 64.60% <37.03%> (-0.63%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/curl.go 16.39% <0.00%> (-0.28%) :arrow_down:
gateway/gateway.go 34.93% <0.00%> (-7.09%) :arrow_down:
gateway/platform/platform.go 67.12% <58.33%> (-0.57%) :arrow_down:
commands/curl_post.go 83.33% <100.00%> (+2.08%) :arrow_up:
mapper/platform/platform.go 97.16% <100.00%> (+0.32%) :arrow_up: