search

opensearch-project / opensearch-cli

A full-featured command line interface (CLI) for OpenSearch.
https://opensearch.org/docs/latest/clients/cli/
Apache License 2.0
44 stars 24 forks source link

Adding opensearch versions to integration test matrix #89

Closed VachaShah closed 1 year ago

VachaShah commented 1 year ago

Description

Updating test matrix with all OpenSearch versions

Issues Resolved

[List any issues this PR will resolve]

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 year ago

Codecov Report

Merging #89 (70ffb31) into main (4a6cae6) will not change coverage. Report is 1 commits behind head on main. The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   64.60%   64.60%           
=======================================
  Files          32       32           
  Lines        2328     2328           
=======================================
  Hits         1504     1504           
  Misses        716      716           
  Partials      108      108
Flag Coverage Δ
opensearch-cli 64.60% <83.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller/config/config.go 67.85% <100.00%> (ø)
handler/ad/ad.go 87.73% <100.00%> (ø)
mapper/platform/platform.go 97.16% <100.00%> (ø)
gateway/gateway.go 34.93% <50.00%> (ø)
VijayanB commented 1 year ago

I believe you are testing only against latest min/max version, not all versions.

VachaShah commented 1 year ago

I believe you are testing only against latest min/max version, not all versions.

Yeah I chose the max version in a minor line since the matrix would be exceptionally huge otherwise. The assumption being that if the compatibility works for the highest version in a minor line (for example 1.3.8), it will work against all 1.3.x since there shouldn't be any breaking changes in the minor line.