search

opensearch-project / opensearch-dashboards-functional-test

Maintains functional tests for OpenSearch Dashboards and Dashboards plugins
Apache License 2.0
12 stars 110 forks source link

[FEATURE] Adding .nvmrc and matching OSD node version #400

Open amitgalitz opened 1 year ago

amitgalitz commented 1 year ago

Is your feature request related to a problem?

We currently don't have a way to enforce what node version is being used, I believe it makes sense to match whatever OSD is using. We should add a .nvmrc file at the very least manually matching what is in OSD.

What solution would you like?

Adding .nvmrc file, doc for using nvm use and a test checking version match same as OSD has.

Just opening an issue incase there is something I'm not aware of that means test repo shouldn't have same node version as OSD. If not then I'll quickly add this.

ashwin-pc commented 1 year ago

I like this, do you want to make a quick contribution for this @amitgalitz?

tianleh commented 1 year ago

It is using the node in the Docker image for running test

amitgalitz commented 1 year ago

It is using the node in the Docker image for running test

For local testing though there isn't anything as far as I'm aware when not using docker

ashwin-pc commented 1 year ago

Yep i ran into this too, and using a different version of node actually broke local testing for me.