Closed Jakob3xD closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.70%. Comparing base (
06a6dc8
) to head (c619002
).
Looks like a publicly-facing backwards-incompatible breaking change? Unless you want to inherit these error types in old names and mark those deprecated, let's bump the version to 4 as part of it?
I adjusted the upgrading.md to version 4.0.0. Do you want the release done in this PR or after all my other PRs are merged? I'd prefer after all the others are merged.
Looks like a publicly-facing backwards-incompatible breaking change? Unless you want to inherit these error types in old names and mark those deprecated, let's bump the version to 4 as part of it?
I adjusted the upgrading.md to version 4.0.0. Do you want the release done in this PR or after all my other PRs are merged? I'd prefer after all the others are merged.
After. Usually the version number should be set on working code as early as possible so that nobody confuses it with released code of the previous version.
Description
This is a braking change as the error types are moved to another project and also get renamed. Needed as preparation for plugin integrations.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.