Closed jackh-ncl closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.93%. Comparing base (
06a6dc8
) to head (cf059ca
). Report is 15 commits behind head on main.
We do need tests for existing and new code, can you please add something simple that exercises params, please?
@dblock I have pushed up some simple tests, though it's proving a bit difficult to get it right as the get()
method is unexported, and golanglint wants test files to be under a test package (e.g. opensearchapi_test
), which means I'm unable to access it.
I can either add make get()
exported, add a nolint
or it looks like I could follow this sort of structure, though I'm not too familiar with this approach.
Would appreciate any suggestions 😃
Thank you 😃
Description
Added
search_pipeline
field in SearchParams struct.Note: I didn't add any tests as I can't see any others there for existing
SearchParam
fields.Context:
With the addition of hybrid search and search pipelines in Opensearch version
2.11
, a newsearch_pipeline
parameter exists on the_search
endpoint (docs here).Issues Resolved
This pull request supports the new search pipelines functionality by allowing users of the library to set the
search_pipeline
parameter via theSearchParams
struct.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.