opensearch-project / opensearch-go

Go Client for OpenSearch
https://opensearch.org/docs/latest/clients/go/
Apache License 2.0
188 stars 96 forks source link

Fix ISM Plugin Transitions Conditions struct (#555) #556

Closed emtammaru closed 1 month ago

emtammaru commented 1 month ago

Issues Resolved

Closes https://github.com/opensearch-project/opensearch-go/issues/555

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.96%. Comparing base (06a6dc8) to head (a5b3c1b). Report is 28 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #556 +/- ## =========================================== + Coverage 57.29% 67.96% +10.67% =========================================== Files 315 376 +61 Lines 9823 8853 -970 =========================================== + Hits 5628 6017 +389 + Misses 2902 1555 -1347 + Partials 1293 1281 -12 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/opensearch-go/pull/556/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/opensearch-project/opensearch-go/pull/556/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `60.39% <ø> (+9.55%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/opensearch-project/opensearch-go/pull/556/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `15.28% <ø> (+2.43%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/opensearch-project/opensearch-go/pull/556?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [plugins/ism/api\_policies.go](https://app.codecov.io/gh/opensearch-project/opensearch-go/pull/556?src=pr&el=tree&filepath=plugins%2Fism%2Fapi_policies.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#diff-cGx1Z2lucy9pc20vYXBpX3BvbGljaWVzLmdv) | `100.00% <ø> (ø)` | | ... and [273 files with indirect coverage changes](https://app.codecov.io/gh/opensearch-project/opensearch-go/pull/556/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)
dblock commented 1 month ago

One more reason for #284, maybe @emtammaru you have some thoughts as a first time contributor.

emtammaru commented 1 month ago

Thanks for the quick turnaround on this fix @dblock. Regarding https://github.com/opensearch-project/opensearch-go/issues/284, that would probably be best if all the types could be generated from a single spec :)

dblock commented 1 month ago

Maybe you're interested in helping? :) wink wink

emtammaru commented 1 month ago

image

Will think about it haha maybe on a rainy day. Has anyone else started on it yet?

dblock commented 1 month ago

Has anyone else started on it yet?

I don't believe so.