Closed emtammaru closed 2 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.96%. Comparing base (
06a6dc8
) to head (a907e9d
). Report is 40 commits behind head on main.
Thanks! This needs a rebase.
The proposal in #284 might be of interest. Also appreciate if you could take this opportunity to check https://github.com/opensearch-project/opensearch-api-specification for these fields and maybe add a test there.
Thanks! This needs a rebase.
The proposal in #284 might be of interest. Also appreciate if you could take this opportunity to check https://github.com/opensearch-project/opensearch-api-specification for these fields and maybe add a test there.
Thank you, I checked the spec and I see the fields under response for https://opensearch-project.github.io/opensearch-api-specification/#/default/search.0. Could you point me to where I could add a test for it in https://github.com/opensearch-project/opensearch-api-specification?
I think https://github.com/opensearch-project/opensearch-api-specification/blob/73d552477f8f006f5ff49f451494d150b8378b18/tests/_core/search.yaml would be a logical place. As long as these are mentioned somewhere.
Description
Adds the missing fields
SeqNo
andPrimaryTerm
to theSearchHit
struct. These fields are optionally returned in the response as documented here with theseq_no_primary_term
param: https://opensearch.org/docs/latest/api-reference/search/Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.