search

opensearch-project / opensearch-go

Go Client for OpenSearch
https://opensearch.org/docs/latest/clients/go/
Apache License 2.0
197 stars 102 forks source link

Remove workflow test against gotip #604

Closed Jakob3xD closed 1 month ago

Jakob3xD commented 1 month ago

Description

In the past we tested the code against gotip to check if upcoming golang versions would break the application. The tests only worked because of some sort of workaround as the setup-go ci job does not support tip, which stopped working. https://github.com/actions/setup-go/issues/21

I don't think we require this test.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.99%. Comparing base (06a6dc8) to head (aa764b0). Report is 59 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #604 +/- ## =========================================== + Coverage 57.29% 67.99% +10.70% =========================================== Files 315 376 +61 Lines 9823 8862 -961 =========================================== + Hits 5628 6026 +398 + Misses 2902 1555 -1347 + Partials 1293 1281 -12 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/opensearch-go/pull/604/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/opensearch-project/opensearch-go/pull/604/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `60.35% <ø> (+9.51%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/opensearch-project/opensearch-go/pull/604/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `15.37% <ø> (+2.53%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more. [see 274 files with indirect coverage changes](https://app.codecov.io/gh/opensearch-project/opensearch-go/pull/604/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project)