opensearch-project / opensearch-java

Java Client for OpenSearch
Apache License 2.0
122 stars 183 forks source link

[FEATURE] IcuCollationKeywordProperty - Add language, country and variant parameters #1186

Open 3M35 opened 2 months ago

3M35 commented 2 months ago

Is your feature request related to a problem?

Im not sure, if i'm missing something, but i cant find a way to set the language, country and variant parameters for the icu_collation_keyword through the java-client.

What solution would you like?

Add language, country and variant parameters to IcuCollationKeywordProperty

What alternatives have you considered?

None

Do you have any additional context?

Im using Version 2.14.0 of the client and i'm trying to set these parameters like described here: https://www.elastic.co/guide/en/elasticsearch/plugins/7.10/analysis-icu-collation-keyword-field.html Here's Elastics IcuCollationProperty with the suggested parameters: https://artifacts.elastic.co/javadoc/co/elastic/clients/elasticsearch-java/8.15.0/co/elastic/clients/elasticsearch/_types/mapping/IcuCollationProperty.html

andrross commented 1 month ago

[Catch All Triage - 1, 2, 3]

@3M35 Looks like this is missing. Care to attempt a PR to fix this?

3M35 commented 4 weeks ago

@andrross Don't think, i would be able to at the moment due to a lack of time and experience.