opensearch-project / opensearch-java

Java Client for OpenSearch
Apache License 2.0
124 stars 183 forks source link

[Feature Request] Implements indexSettings similarity. #987

Open ritty27 opened 6 months ago

ritty27 commented 6 months ago

Is your feature request related to a problem? Please describe

Currently, there is no similarity setting in indexSettings when creating new index through CreateIndexRequest in opensearch. The Elasitcsearch java-client also has this feature, but the openSearch java-client does not provide this feature.

"similarity": {
  "custom_similarity": {
    "type": "BM25",
    "k1": 1.2,
    "b": 0.75,
    "discount_overlaps": "true"
  }
}

Describe the solution you'd like

Add a similarity setting when an index is created using java-client.

Related component

Indexing

Describe alternatives you've considered

Implement similar to the code implemented in elasticsearch.

Additional context

No response

owaiskazi19 commented 6 months ago

@ritty27 thanks for creating the issue. The right place for this issue would be in https://github.com/opensearch-project/opensearch-java. @opensearch-project/admin can you transfer this issue? Thanks

ritty27 commented 6 months ago

@owaiskazi19 I created a PR for the issue on https://github.com/opensearch-project/OpenSearch, should I also move the PR? PR Link : https://github.com/opensearch-project/OpenSearch/pull/13631

owaiskazi19 commented 6 months ago

@owaiskazi19 I created a PR for the issue on https://github.com/opensearch-project/OpenSearch, should I also move the PR? PR Link : opensearch-project/OpenSearch#13631

Yes, you can close out the PR and open a new one in opensearch-java.