Testing different versions of aws-sdk

opensearch-project / opensearch-js

Node.js Client for OpenSearch

https://opensearch.org/docs/latest/clients/javascript/

Apache License 2.0

176 stars 116 forks source link

Testing different versions of aws-sdk #760

Open nhtruong opened 2 months ago

nhtruong commented 2 months ago

Coming from https://github.com/opensearch-project/opensearch-js/pull/758

We currently supports both v2 and v3 of aws-sdk to interact with Sigv4 enabled domain with 2 different ways to load up these dependencies, which resulted in 4 different tests cases that we will need to setup 4 different Node envs for:

AwsSigv4Signer with aws-v2
AwsSigv4Signer with aws-v3
AwsSigv4SignerV3 with aws-v3
AwsSigv4SignerV3 without aws-v3

tusharf5 commented 1 month ago

Let me know if I can take a stab at this

dblock commented 1 month ago

@tusharf5 Definitely!