opensearch-project / opensearch-js

Node.js Client for OpenSearch
https://opensearch.org/docs/latest/clients/javascript/
Apache License 2.0
189 stars 123 forks source link

Upgrade JSON11 from 1.1.2 to 2.0.0 #885

Closed AMoo-Miki closed 2 weeks ago

AMoo-Miki commented 1 month ago

Description

Upgrade JSON11 from 1.1.2 to 2.0.0 to ensure UTF-8 safety when stringifying JSON data.

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dblock commented 1 month ago

It's a breaking sort of change, do we want it here @nhtruong? Consumers should be able to lock > 2.0 in their application's package.lock if I am not mistaken.

nhtruong commented 1 month ago

@AMoo-Miki it's a fork of JSON5 you're maintaining right? https://github.com/AMoo-Miki/json11 If this is a breaking changes for 2.x users, we should move this to the 3x release. If not, feel free to merge.