However the current unit test sets the contentLength off of MAX_STRING_LENGTH instead of HEAP_SIZE_LIMIT. This results in the test failing on earlier versions of node.js where heapUsed is smaller and doesn't cause contentLength + heapUsed > HEAP_SIZE_LIMIT * maxPercentage to return true.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Here's the actual code in Transport.js:
However the current unit test sets the contentLength off of
MAX_STRING_LENGTH
instead ofHEAP_SIZE_LIMIT
. This results in the test failing on earlier versions of node.js whereheapUsed
is smaller and doesn't causecontentLength + heapUsed > HEAP_SIZE_LIMIT * maxPercentage
to return true.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.