Closed nilushancosta closed 4 months ago
nilushancosta
commented
4 months ago As part of this fix, I modified 2 files; opensearch-operator/pkg/reconcilers/ismpolicy.go and docs/developing.md. However when I executed make build manifests, other files also got modified automatically. Since these modifications included changes to the CRD YAMLs, I copied them to the Helm chart as per the instructions in the developer guide. Please let me know if what I did is correct
swoehrl-mw
commented
4 months ago @nilushancosta On second thought, please remove all the crd yaml changes from the PR (from the chart and the config/crd/bases folder), we'll deal with that separately since the wrong field name (timestamp_field vs timestampField) in the YAMLs is already part of the 2.6.0 release so cannot be changed without causing inconsistencies.
cc @prudhvigodithi @salyh
nilushancosta
commented
4 months ago @nilushancosta On second thought, please remove all the crd yaml changes from the PR (from the chart and the config/crd/bases folder), we'll deal with that separately since the wrong field name (
timestamp_fieldvstimestampField) in the YAMLs is already part of the 2.6.0 release so cannot be changed without causing inconsistencies.cc @prudhvigodithi @salyh
Updated the PR by removing them
Description
Add retry for opensearch client creation in ISM policy reconciler to fix panic Minor change - Remove extra whitespace in developing.md file
Issues Resolved
Resolves https://github.com/opensearch-project/opensearch-k8s-operator/issues/801
Check List
make lint)If CRDs are changed:
make manifests) and also copied into the helm chartPlease refer to the PR guidelines before submitting this pull request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.