opensearch-project / opensearch-k8s-operator

OpenSearch Kubernetes Operator
Apache License 2.0
404 stars 218 forks source link

[BUG] opensearch-cluster chart : imagepullsecret for general and dashboard #904

Open xav-hydra opened 1 week ago

xav-hydra commented 1 week ago

What is the bug?

In Opensearch cluster helm chart imagepullsecret not templated for dashboard and general

How can one reproduce the bug?

/

What is the expected behavior?

to have an imagepullsecret setting in template like inithelper does as it works when you modify the manifest generated with dry-run in an helm upgrade/install

What is your host/environment?

running opensearch in k8s, setup via operator and cluster helm charts

Do you have any screenshots?

/

Do you have any additional context?

Solution is to add imagepullsecret to template for general and dashboard sections, like in initcontainer https://github.com/opensearch-project/opensearch-k8s-operator/blob/main/charts/opensearch-cluster/templates/opensearch-cluster-cr.yaml#L23-L26

xav-hydra commented 1 week ago

here is a draft PR to show the easy resolution of this bug https://github.com/opensearch-project/opensearch-k8s-operator/pull/905