search

opensearch-project / opensearch-learning-to-rank-base

Fork of https://github.com/o19s/elasticsearch-learning-to-rank to work with OpenSearch
Apache License 2.0
14 stars 11 forks source link

2.10 #24

Open macohen opened 7 months ago

macohen commented 7 months ago

Description

updates the build to use OpenSearch 2.10, but fails due to refactoring needed.

Issues Resolved

N.A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

austintlee commented 6 months ago

I had a look at the diff and looked for similar changes we had made for ml-commons. Looks like they're all there (MediaType, XContentParser, etc).

macohen commented 6 months ago

I had a look at the diff and looked for similar changes we had made for ml-commons. Looks like they're all there (MediaType, XContentParser, etc).

Thanks @austintlee. @mkhludnev managed to find that some of the tests pass if you override ToXContent.isFragment() and return true. I found that some of them fail so there's more digging to do on this one.