Restrict the range of JVMs that need security policy flags set

opensearch-project / opensearch-learning-to-rank-base

Fork of https://github.com/o19s/elasticsearch-learning-to-rank to work with OpenSearch

Apache License 2.0

16 stars 15 forks source link

Restrict the range of JVMs that need security policy flags set #42

Closed sstults closed 2 months ago

sstults commented 2 months ago

Description

We currently test against versions 11, 17, and 21. For version 17 we need to add a policy file, but for version 21 the security manager flags throw an error. This PR restricts the versions that need the flags set to > 11 and < 21.

Issues Resolved

n/a

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

sstults commented 2 months ago

It seems like there is a threading issue. I can exacerbate the problem by running the tests on a hotspot JVM, and most of the errors happen here in Suppliers.java. What I can't tell yet is whether this is a problem at runtime or if it's just a problem during testing. I'm moving this PR to the draft state until that gets figured out.

jzonthemtn commented 2 months ago

I have been getting intermittent failures when building locally and in GitHub Actions. This failure is different than the failed test case in this build but it wouldn't surprise me if it's related.

Tests with failures:
 - com.o19s.es.ltr.query.LtrQueryTests.testNoMatchQueries

I'd say the build passes every 2 out of 3 times for me.

sstults commented 2 months ago

It looks like this issue was addressed in this PR for ES-LTR. After bringing this change over I'm getting reliable builds locally.

macohen commented 2 months ago

Tests passed! Closing.