search

opensearch-project / opensearch-metrics

OpenSearch Metrics
https://metrics.opensearch.org
Apache License 2.0
2 stars 4 forks source link

Added docker pushing logs to cloudwatch functionality #50

Closed bshien closed 3 months ago

bshien commented 3 months ago

Description

  1. Changes docker log driver to awslogs so docker can push logs to cloudwatch.
  2. Tuned canary alarm settings
  3. Added and refactored tests for NginxProxyReadonly
  4. Refactored SecretStack name

Logs look like this in Cloudwatch:

Screenshot 2024-06-26 at 3 51 48 PM

Issues Resolved

https://github.com/opensearch-project/opensearch-metrics/issues/47

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.77%. Comparing base (50d617b) to head (aefe405).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #50 +/- ## ============================================ + Coverage 76.69% 76.77% +0.08% Complexity 179 179 ============================================ Files 52 52 Lines 1124 1128 +4 Branches 49 49 ============================================ + Hits 862 866 +4 Misses 239 239 Partials 23 23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

prudhvigodithi commented 3 months ago

Thanks @bshien, if possible can we remove the special characters in the log next to INFO and DEBUG?

prudhvigodithi commented 3 months ago

Thanks @bshien, if possible can we remove the special characters in the log next to INFO and DEBUG?

Having a log formatter to awssigv4proxy should help fix the special characters. https://forums.docker.com/t/how-to-turn-off-the-log-color-mark-output-by-stdout/117429

prudhvigodithi commented 3 months ago

Merging this as there is some issue with mend and not related to this code change. Thanks