opensearch-project / opensearch-migrations

Migrate, upgrade, compare, and replicate OpenSearch clusters with ease.
https://aws.amazon.com/solutions/implementations/migration-assistant-for-amazon-opensearch-service/
Apache License 2.0
39 stars 29 forks source link

Remove arg printing from command line apps with secret values #1024

Closed AndreKurait closed 1 month ago

AndreKurait commented 1 month ago

Description

CreateSnapshot, DocumentsFromSnapshotMigration, and MetadataMigration printed args which could contain secret value password

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.25%. Comparing base (2c1f760) to head (61dd72f). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1024 +/- ## ============================================ + Coverage 80.24% 80.25% +0.01% Complexity 2722 2722 ============================================ Files 365 365 Lines 13615 13612 -3 Branches 941 941 ============================================ - Hits 10925 10924 -1 + Misses 2115 2113 -2 Partials 575 575 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1024/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [gradle-test](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `78.22% <100.00%> (+0.01%)` | :arrow_up: | | [python-test](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `90.11% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.