opensearch-project / opensearch-migrations

Migrate, upgrade, compare, and replicate OpenSearch clusters with ease.
https://aws.amazon.com/solutions/implementations/migration-assistant-for-amazon-opensearch-service/
Apache License 2.0
39 stars 29 forks source link

Add unit tests for RemoteReaderClient #1116

Closed AndreKurait closed 2 weeks ago

AndreKurait commented 2 weeks ago

Description

Add unit tests. Followup from https://github.com/opensearch-project/opensearch-migrations/pull/1114/files

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Unit test

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.46%. Comparing base (e78d172) to head (616ebed). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1116 +/- ## ============================================ + Coverage 80.40% 80.46% +0.05% - Complexity 2944 2947 +3 ============================================ Files 393 393 Lines 14536 14536 Branches 1001 1001 ============================================ + Hits 11688 11696 +8 + Misses 2242 2235 -7 + Partials 606 605 -1 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1116/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [gradle-test](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1116/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `78.53% <ø> (+0.06%)` | :arrow_up: | | [python-test](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1116/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `90.33% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.