Closed peternied closed 2 weeks ago
Attention: Patch coverage is 77.01149%
with 20 lines
in your changes missing coverage. Please review.
Project coverage is 80.55%. Comparing base (
48da9ce
) to head (754e316
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@gregschohn Thanks for the great suggestion, the nodes API is much more trust worthy IMO. I've swapped out the plugins api for it, it was a relatively simple change.
For reusing this code elsewhere, I think we have a complicated story about how that can work today. I'd prefer to move forward with this implementation and we can figure out how and where to make this logic available in other parts of the migration ecosystem and what the best way to do that is.
We'll need this functionality (very soon) to determine how to transform metadata from a source version to a target version, right? That problem isn't constrained to just one java program. It isn't even just constrained to our suite of java programs.
+1, makes sense. I'm sure we'll be revisiting this soon.
I'd prefer to move forward with this implementation and we can figure out how and where to make this logic available in other parts of the migration ecosystem
That makes sense to me, thanks for the work on this @peternied . Thanks also to @gregschohn for the suggestion on the Nodes API, it alleviates a lot of my concern about brittleness.
Description
Adding automatic version detection that supports both flavors of the Amazon Managed OpenSearch and Serverless offerings. Also detecting if combability mode has been enabled that will extract the version number from the
_cat/plugins
api, specifically looking at therepository-s3
plugin.Issues Resolved
Testing
Tested with both a managed and serverless cluster locally.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.