opensearch-project / opensearch-migrations

Migrate, upgrade, compare, and replicate OpenSearch clusters with ease.
https://aws.amazon.com/solutions/implementations/migration-assistant-for-amazon-opensearch-service/
Apache License 2.0
39 stars 28 forks source link

Use CFN input for VPC id and Stage #1122

Closed lewijacn closed 2 weeks ago

lewijacn commented 2 weeks ago

Description

Make this input available on the bootstrap instance, and fill in appropriate CDK context if available

Issues Resolved

https://opensearch.atlassian.net/browse/MIGRATIONS-2205

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Manual deployments for both paths to CFN

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.54%. Comparing base (c189ced) to head (5e2f69f). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1122 +/- ## ============================================ + Coverage 80.51% 80.54% +0.03% - Complexity 2871 2907 +36 ============================================ Files 393 393 Lines 14554 14630 +76 Branches 1000 1007 +7 ============================================ + Hits 11718 11784 +66 - Misses 2229 2233 +4 - Partials 607 613 +6 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1122/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [gradle-test](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `78.65% <ø> (+0.05%)` | :arrow_up: | | [python-test](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `90.33% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.