opensearch-project / opensearch-migrations

Migrate, upgrade, compare, and replicate OpenSearch clusters with ease.
https://aws.amazon.com/solutions/implementations/migration-assistant-for-amazon-opensearch-service/
Apache License 2.0
39 stars 28 forks source link

[CDK] Validate source endpoint and add default port if missing #1125

Closed lewijacn closed 1 week ago

lewijacn commented 2 weeks ago

Description

Validate endpoints for source and target and add default ports if missing. This should result in a consistent pattern for our endpoints in CDK and prevent Capture Proxy errors from providing a destinationURI without a port.

Issues Resolved

https://opensearch.atlassian.net/browse/MIGRATIONS-2035

Is this a backport? If so, please add backport PR # and/or commits #

Testing

CDK testing

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.54%. Comparing base (bcd38c6) to head (3d8a2ce). Report is 12 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1125 +/- ## ========================================= Coverage 80.54% 80.54% Complexity 2907 2907 ========================================= Files 393 393 Lines 14630 14630 Branches 1007 1007 ========================================= Hits 11784 11784 Misses 2233 2233 Partials 613 613 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1125/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [gradle-test](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1125/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `78.65% <ø> (ø)` | | | [python-test](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1125/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `90.33% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.