Closed AndreKurait closed 1 week ago
Attention: Patch coverage is 92.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 80.70%. Comparing base (
41bbfc4
) to head (adb819e
). Report is 2 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
...load/version_es_6_8/GlobalMetadataData_ES_6_8.java | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Could you also please provide the before/after of what the template from legacy to latest? That could be in the PR or (better), the commit message.
Added context in the PR Overview. This isn't net-new transformation or functionality, just doing the same processing on the templates mapping
key that we apply in ES7 indexes (and ES6 templates/indexes)
Description
Currently, legacy templates (created with
_template
) were only supported on ES 6. Since the API is deprecated and not removed, customers still use this type of template for ES 7 and above and it should be supported and tested.This change mirrors the existing transformation logic that is in Index processing and applying to Legacy templates for ES7. E.g.
Issues Resolved
MIGRATIONS-2217
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Added E2E tests across different criteria for legacy templates on all versions with snapshot and api retrieval
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.