opensearch-project / opensearch-migrations

Migrate, upgrade, compare, and replicate OpenSearch clusters with ease.
https://aws.amazon.com/solutions/implementations/migration-assistant-for-amazon-opensearch-service/
Apache License 2.0
39 stars 28 forks source link

Sonarqube fixes from subshard work coordination #1151

Closed mikaylathompson closed 2 days ago

mikaylathompson commented 2 days ago

Description

Sonarqube had a few complaints about details of the sub-shard work coordination implementation. Quick fixes in this PR.

Issues Resolved

n/a individual issues linked in comments

Testing

n/a

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.72%. Comparing base (176eefd) to head (233eaf8). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1151 +/- ## ============================================ - Coverage 80.75% 80.72% -0.04% + Complexity 2953 2952 -1 ============================================ Files 399 399 Lines 15101 15106 +5 Branches 1021 1021 ============================================ - Hits 12195 12194 -1 - Misses 2292 2298 +6 Partials 614 614 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1151/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1151/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `80.72% <ø> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: