opensearch-project / opensearch-migrations

Migrate, upgrade, compare, and replicate OpenSearch clusters with ease.
https://aws.amazon.com/solutions/implementations/migration-assistant-for-amazon-opensearch-service/
Apache License 2.0
39 stars 28 forks source link

Refactor online radix sorter #1156

Closed gregschohn closed 19 hours ago

gregschohn commented 1 day ago

Description

Moves the TrackedFuture classes and OnlineRadixSorter into coreUtilities.

The only change to logic was to move some Jackson formatting from a class into a single test & taking a test dependency on Jackson. We did have an implementation dependency on jackson, but that's been converted to just a testDependency. It wasn't needed to build and makes the cost of using coreUtilities much greater for others.

Issues Resolved

no issue, but related to 2128

Testing

gradle

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@41e0b5d). Learn more about missing BASE report. Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1156 +/- ## ======================================= Coverage ? 80.73% Complexity ? 2951 ======================================= Files ? 400 Lines ? 15104 Branches ? 1021 ======================================= Hits ? 12194 Misses ? 2297 Partials ? 613 ``` | [Flag](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1156/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/opensearch-project/opensearch-migrations/pull/1156/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) | `80.73% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: